CurtHagenlocher commented on code in PR #1507:
URL: https://github.com/apache/arrow-adbc/pull/1507#discussion_r1477313302
##########
csharp/src/Drivers/BigQuery/BigQueryConnection.cs:
##########
@@ -1014,6 +1032,10 @@ public override AdbcStatement CreateStatement()
{
options[keyValuePair.Key] = keyValuePair.Value;
}
+ if(keyValuePair.Key ==
BigQueryParameters.LargeResultsDestinationTable)
Review Comment:
> ~it's up to the driver, but mostly we've been case sensitive so far
This seems like something we'd want to provide guidance around to improve
standardization e.g. "case-sensitive but consistently lower-case keys"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
