berkaysynnada commented on PR #8891: URL: https://github.com/apache/arrow-datafusion/pull/8891#issuecomment-1932192763
> @berkaysynnada, can you please ellaborate on the signature of the new `visit`/`rewrite` API you are proposing? I have not detailed the signatures yet but theoretically there is no difficulty for the calls, they could have very similar to your updated `visit()` and `rewrite()` implementations. Users can call visit() (or rewrite()) on their trees, and if they have implemented pre_visit() or post_visit(), they are applied accordingly. Otherwise, the calls simply return self with transformed::no and tnr::stop by default. In this way, we can eliminate also Visitor and Rewriter traits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
