berkaysynnada commented on PR #8891: URL: https://github.com/apache/arrow-datafusion/pull/8891#issuecomment-1933523802
> ~I think `Skip` in my PR and `Jump` in your proposal do the same~, I updated my PR description to avoid confusion. > > **Update**: I'm no longer sure they do the same, but not sure how `Jump` would be useful, I think we simply need an option to prevent recursing into children. If you are talking about transformations, Stop and Jump already prevent recursing into children. They also provide an option asking you to continue with other subtrees or completely finish the transformation. If you mean in visitor/rewriter context, during the pre-visits, Stop and Jump do the same behavior, too. During post-visits, jumping to the node which the subtree disjoined is the most expectable and useful behavior, I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
