berkaysynnada commented on PR #8891: URL: https://github.com/apache/arrow-datafusion/pull/8891#issuecomment-1932230705
> Sorry if I still don't get it, but the signatures of your suggested `pre_visit()` and `post_visit()` should be exactly the same as `f_down()` and `f_up()` in my `TreeNodeRewriter` in the descriptions? I.e. `fn f_down(&mut self, node: Self::Node) -> Result<Transformed<Self::Node>>`? > > I'm not sure I get the difference of your proposal to the `TreeNodeRewriter` in my PR. You are right, very likely they will be like those. I would like to question do we need separate TreeNodeRewriter trait, or encapsulate it within TreeNode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
