advancedxy commented on code in PR #45:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/45#discussion_r1494729765
##########
.github/actions/java-test/action.yaml:
##########
@@ -35,9 +35,17 @@ runs:
- name: Run Maven compile
shell: bash
run: |
- ./mvnw compile test-compile scalafix:scalafix -Psemanticdb
+ if [ $JAVA_VERSION == "8" ]; then
+ ./mvnw -B compile test-compile scalafix:scalafix -Psemanticdb
-Djava.version=1.8
Review Comment:
This is mainly to set `-Djava.version` which is different from 8.
##########
.github/actions/setup-builder/action.yaml:
##########
@@ -38,7 +38,7 @@ runs:
- name: Install JDK ${{inputs.jdk-version}}
uses: actions/setup-java@v4
with:
- distribution: 'adopt'
+ distribution: 'zulu'
Review Comment:
zulu supports arm(m1/m2) mac with JDK 8
##########
common/src/main/java/org/apache/comet/parquet/FileReader.java:
##########
@@ -882,6 +882,8 @@ private class ConsecutivePartList {
private final SQLMetric readThroughput;
/**
+ * Constructor
Review Comment:
This is only to make mvn spotless work for both java 1.8 and java 17.
Otherwise, running spotless with java 1.8 will make this java doc one line.
##########
spark/src/test/scala/org/apache/spark/sql/GenTPCHData.scala:
##########
@@ -76,7 +76,7 @@ object GenTPCHData {
// Generate data
// Since dbgen may uses stdout to output the data, tables.genData needs to
run table by table
val tableNames =
- if (config.tableFilter.isBlank) tables.tables.map(_.name) else
Seq(config.tableFilter)
+ if (config.tableFilter.trim.isEmpty) tables.tables.map(_.name) else
Seq(config.tableFilter)
Review Comment:
java8 compatible.
##########
.github/actions/rust-test/action.yaml:
##########
@@ -49,15 +49,24 @@ runs:
shell: bash
run: |
cd common
- ../mvnw clean compile -DskipTests
+ if [ $JAVA_VERSION == "8" ]; then
+ ../mvnw clean -B compile -DskipTests -Djava.version=1.8
+ else
+ ../mvnw clean -B compile -DskipTests -Djava.version=${JAVA_VERSION}
+ fi
- name: Run Cargo test
shell: bash
run: |
cd core
# This is required to run some JNI related tests on the Rust side
+
JAVA_LD_LIBRARY_PATH=$JAVA_HOME/lib/server:$JAVA_HOME/lib:$JAVA_HOME/lib/jli
+ # special handing for java 1.8 for both linux and mac distributions
+ if [ $JAVA_VERSION == "8" ]; then
+
JAVA_LD_LIBRARY_PATH=$JAVA_HOME/jre/lib/amd64/server:$JAVA_HOME/jre/lib/amd64:$JAVA_HOME/jre/lib/amd64/jli:$JAVA_HOME/jre/lib/server:$JAVA_HOME/jre/lib:$JAVA_HOME/jre/lib/jli
Review Comment:
Linux and Mac have different lib paths for JDK 1.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
