advancedxy commented on code in PR #45:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/45#discussion_r1495091338
##########
.github/actions/java-test/action.yaml:
##########
@@ -35,9 +35,17 @@ runs:
- name: Run Maven compile
shell: bash
run: |
- ./mvnw compile test-compile scalafix:scalafix -Psemanticdb
+ if [ $JAVA_VERSION == "8" ]; then
+ ./mvnw -B compile test-compile scalafix:scalafix -Psemanticdb
-Djava.version=1.8
Review Comment:
Oh, I forget to mention `-B` is used to trigger the Batch mode, which
suppresses download progress bar.
##########
.github/actions/setup-builder/action.yaml:
##########
@@ -38,7 +38,7 @@ runs:
- name: Install JDK ${{inputs.jdk-version}}
uses: actions/setup-java@v4
with:
- distribution: 'adopt'
+ distribution: 'zulu'
Review Comment:
Addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
