advancedxy commented on code in PR #45:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/45#discussion_r1495092979
##########
.github/workflows/pr_build.yml:
##########
@@ -35,105 +35,89 @@ on:
workflow_dispatch:
env:
- JAVA_VERSION: 17
RUST_VERSION: nightly
jobs:
- linux-rust-test:
- name: Rust test (amd64)
- runs-on: ubuntu-latest
+ linux-java-or-rust-test:
+ strategy:
+ matrix:
+ os: [ubuntu-latest]
+ java_version: [8, 17]
+ test-target: [rust, java]
+ fail-fast: false
+ name: ${{ matrix.test-target }} test on ${{ matrix.os }} with java ${{
matrix.java_version }}
+ runs-on: ${{ matrix.os }}
container:
image: amd64/rust
+ env:
+ JAVA_VERSION: ${{ matrix.java_version }}
steps:
- uses: actions/checkout@v4
- name: Setup Rust & Java toolchain
uses: ./.github/actions/setup-builder
with:
rust-version: ${{env.RUST_VERSION}}
- jdk-version: ${{env.JAVA_VERSION}}
+ jdk-version: ${{ matrix.java_version }}
- uses: actions/checkout@v4
- - name: Rust test steps
+ - if: matrix.test-target == 'rust'
+ name: Rust test steps
uses: ./.github/actions/rust-test
-
- linux-java-test:
- name: Java test (amd64)
- runs-on: ubuntu-latest
- container:
- image: amd64/rust
- steps:
- - uses: actions/checkout@v4
- - name: Setup Rust & Java toolchain
- uses: ./.github/actions/setup-builder
- with:
- rust-version: ${{env.RUST_VERSION}}
- jdk-version: ${{env.JAVA_VERSION}}
-
- - uses: actions/checkout@v4
- - name: Java test steps
+ - if: matrix.test-target == 'java'
+ name: Java test steps
uses: ./.github/actions/java-test
-
- macos-rust-test:
- name: Rust test (macos)
- runs-on: macos-latest
+ macos-java-or-rust-test:
+ strategy:
+ matrix:
+ os: [macos-latest]
+ java_version: [8, 17]
+ test-target: [rust, java]
+ fail-fast: false
+ name: ${{ matrix.test-target }} test on ${{ matrix.os }} with java ${{
matrix.java_version }}
+ runs-on: ${{ matrix.os }}
+ env:
+ JAVA_VERSION: ${{ matrix.java_version }}
steps:
- uses: actions/checkout@v4
- name: Setup Rust & Java toolchain
uses: ./.github/actions/setup-macos-builder
with:
rust-version: ${{env.RUST_VERSION}}
- jdk-version: ${{env.JAVA_VERSION}}
+ jdk-version: ${{ matrix.java_version }}
- uses: actions/checkout@v4
- - name: Rust test steps
+ - if: matrix.test-target == 'rust'
+ name: Rust test steps
uses: ./.github/actions/rust-test
-
- macos-java-test:
- name: Java test (macos)
- runs-on: macos-latest
- steps:
- - uses: actions/checkout@v4
- - name: Setup Rust & Java toolchain
- uses: ./.github/actions/setup-macos-builder
- with:
- rust-version: ${{env.RUST_VERSION}}
- jdk-version: ${{env.JAVA_VERSION}}
-
- - uses: actions/checkout@v4
- - name: Java test steps
+ - if: matrix.test-target == 'java'
+ name: Java test steps
uses: ./.github/actions/java-test
- macos-aarch64-rust-test:
- name: Rust test (macos-aarch64)
+ macos-aarch64-java-or-rust-test:
+ strategy:
+ matrix:
+ java_version: [8, 17]
Review Comment:
@sunchao @viirya do you think is it necessary to add java 11 here?
It may increase the CI run time as mac runners is not sufficient to run CIs
instantly. I noticed the CIs on Macs are waiting a couple of minutes before it
gets picked by a mac runner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
