parthchandra commented on code in PR #45:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/45#discussion_r1496315640
##########
spark/src/test/scala/org/apache/spark/sql/GenTPCHData.scala:
##########
@@ -76,7 +76,7 @@ object GenTPCHData {
// Generate data
// Since dbgen may uses stdout to output the data, tables.genData needs to
run table by table
val tableNames =
- if (config.tableFilter.isBlank) tables.tables.map(_.name) else
Seq(config.tableFilter)
+ if (config.tableFilter.trim.isEmpty) tables.tables.map(_.name) else
Seq(config.tableFilter)
Review Comment:
In general I would avoid using apache commons if the java standard library
has to way to achieve the same. Unless of course there is a measurable
performance gain :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
