advancedxy commented on code in PR #45:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/45#discussion_r1495289693
##########
.github/actions/java-test/action.yaml:
##########
@@ -35,9 +35,17 @@ runs:
- name: Run Maven compile
shell: bash
run: |
- ./mvnw compile test-compile scalafix:scalafix -Psemanticdb
+ if [ $JAVA_VERSION == "8" ]; then
+ ./mvnw -B compile test-compile scalafix:scalafix -Psemanticdb
-Djava.version=1.8
+ else
+ ./mvnw -B compile test-compile scalafix:scalafix -Psemanticdb
-Djava.version=${JAVA_VERSION}
+ fi
- name: Run tests
shell: bash
run: |
- SPARK_HOME=`pwd` ./mvnw clean install
+ if [ $JAVA_VERSION == "8" ]; then
+ SPARK_HOME=`pwd` ./mvnw -B clean install -Djava.version=1.8
Review Comment:
JAVA_VERSION is used by setup-java actions. I believe 8 is required to
correctly setup java 8.
But let me try to set 1.8 in the pr_build.yml rather than in this
action.yaml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
