sunchao commented on code in PR #45:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/45#discussion_r1495276647
##########
.github/actions/setup-macos-builder/action.yaml:
##########
@@ -49,11 +49,17 @@ runs:
unzip $PROTO_ZIP
echo "$HOME/d/protoc/bin" >> $GITHUB_PATH
export PATH=$PATH:$HOME/d/protoc/bin
+ # install openssl to work with JDK 8 loading libcrypto.dylib
+ # see
https://stackoverflow.com/questions/58272830/python-crashing-on-macos-10-15-beta-19a582a-with-usr-lib-libcrypto-dylib
for more details
+ brew install openssl
Review Comment:
@advancedxy could you open a separate PR just for this change? wanna check
if this actually is working. Maybe `macos-latest` + this does the magic ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
