crepererum opened a new pull request, #9307:
URL: https://github.com/apache/arrow-datafusion/pull/9307

   ## Which issue does this PR close?
   Closes #9305.
   
   ## Rationale for this change
   `SchemaProvider::table` is async and clearly allows IO:
   
   
https://github.com/apache/arrow-datafusion/blob/6fad5ed7a37c50b9c200f214c3e13b0e1f0cecbc/datafusion/core/src/catalog/schema.rs#L114-L116
   
   However this method cannot fail. Casting errors to `None` is semantically 
wrong.
   
   ## What changes are included in this PR?
   Change return type from `Option<Arc<dyn TableProvider>>` to 
`Result<Option<Arc<dyn TableProvider>>, DataFusionError>`.
   
   ## Are these changes tested?
   It compiles.
   
   ## Are there any user-facing changes?
   **Breaking:** Interface change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to