jayzhan211 commented on code in PR #9108:
URL: https://github.com/apache/arrow-datafusion/pull/9108#discussion_r1501348925


##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -433,6 +435,7 @@ pub fn array_element(args: &[ArrayRef]) -> Result<ArrayRef> 
{
             let indexes = as_int64_array(&args[1])?;
             general_array_element::<i64>(array, indexes)
         }
+        DataType::Null => Ok(args[0].clone()),

Review Comment:
   Maybe we can ignore nulls as the first argument since we are not coercing 
them to any other type. Unlike, array_append(arr, null) as the second argument, 
in this case, we will convert to other primitives.
   
   `array()` for fixed list to list type coercion only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to