Weijun-H commented on code in PR #9108:
URL: https://github.com/apache/arrow-datafusion/pull/9108#discussion_r1501732814
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -433,6 +435,7 @@ pub fn array_element(args: &[ArrayRef]) -> Result<ArrayRef>
{
let indexes = as_int64_array(&args[1])?;
general_array_element::<i64>(array, indexes)
}
+ DataType::Null => Ok(args[0].clone()),
Review Comment:
> I believe our primary focus within TypeCoercionRewriter should be strictly
on type coercion. If encountering a null value that isn't being cast to another
type, it should be disregarded.
I cannot agree more with that. I should focus on the type coercion, and
leave `NULL` aside now. So I will remove `allow_null_coercion ` and don't check
`null` now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
