jayzhan211 commented on code in PR #9108:
URL: https://github.com/apache/arrow-datafusion/pull/9108#discussion_r1501932831
##########
datafusion/expr/src/built_in_function.rs:
##########
@@ -929,18 +930,18 @@ impl BuiltinScalarFunction {
// 0 or more arguments of arbitrary type
Signature::one_of(vec![VariadicEqual, Any(0)],
self.volatility())
}
- BuiltinScalarFunction::ArrayPopFront => Signature::any(1,
self.volatility()),
- BuiltinScalarFunction::ArrayPopBack => Signature::any(1,
self.volatility()),
+ BuiltinScalarFunction::ArrayPopFront =>
Signature::array(self.volatility()),
+ BuiltinScalarFunction::ArrayPopBack =>
Signature::array(self.volatility()),
BuiltinScalarFunction::ArrayConcat => {
Signature::variadic_any(self.volatility())
}
- BuiltinScalarFunction::ArrayDims => Signature::any(1,
self.volatility()),
- BuiltinScalarFunction::ArrayEmpty => Signature::any(1,
self.volatility()),
+ BuiltinScalarFunction::ArrayDims =>
Signature::array(self.volatility()),
Review Comment:
test is not covered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
