ritchie46 commented on a change in pull request #9361:
URL: https://github.com/apache/arrow/pull/9361#discussion_r569207411
##########
File path: rust/arrow/src/compute/kernels/arithmetic.rs
##########
@@ -35,20 +35,17 @@ use crate::datatypes;
use crate::datatypes::ArrowNumericType;
use crate::error::{ArrowError, Result};
use crate::{array::*, util::bit_util};
+use num::traits::Pow;
#[cfg(simd)]
use std::borrow::BorrowMut;
#[cfg(simd)]
use std::slice::{ChunksExact, ChunksExactMut};
/// Helper function to perform math lambda function on values from single
array of signed numeric
/// type. If value is null then the output value is also null, so `-null` is
`null`.
-pub fn signed_unary_math_op<T, F>(
- array: &PrimitiveArray<T>,
- op: F,
-) -> Result<PrimitiveArray<T>>
+pub fn unary_math_op<T, F>(array: &PrimitiveArray<T>, op: F) ->
Result<PrimitiveArray<T>>
Review comment:
@nevi-me I removed the helper function and used the
`arity::unary::kernel`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
