nevi-me commented on a change in pull request #9361:
URL: https://github.com/apache/arrow/pull/9361#discussion_r571736477
##########
File path: rust/arrow/src/compute/kernels/arithmetic.rs
##########
@@ -536,7 +555,29 @@ where
#[cfg(simd)]
return simd_signed_unary_math_op(array, |x| -x, |x| -x);
#[cfg(not(simd))]
- return signed_unary_math_op(array, |x| -x);
+ return Ok(unary(array, |x| -x));
+}
+
+/// Raise array to the power of a scalar.
+pub fn pow_scalar<T>(
Review comment:
Given that this function is
[powf](https://doc.rust-lang.org/stable/std/primitive.f64.html#method.powf),
WDYT about renaming it as such? We're going to also have `pow` for the integer
types, `powi` to raise floats to an integer power. So we could preempt the
possible rename.
I'll remove the `powf` in #9313 because this one has a SIMD implementation.
An additional benefit of splitting `powf` and `powi` is that `powi` is
faster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
