nevi-me commented on a change in pull request #9361:
URL: https://github.com/apache/arrow/pull/9361#discussion_r571733973
##########
File path: rust/arrow/src/datatypes.rs
##########
@@ -920,6 +930,32 @@ make_signed_numeric_type!(Int64Type, i64x8);
make_signed_numeric_type!(Float32Type, f32x16);
make_signed_numeric_type!(Float64Type, f64x8);
+#[cfg(simd)]
+pub trait ArrowFloatNumericType: ArrowNumericType {
+ fn pow(base: Self::Simd, raise: Self::Simd) -> Self::Simd;
Review comment:
You're right, if it's not possible to only add the trait for SIMD types,
then it's a reasonable change to make.
The downside's that the trait's going to grow when we add more compute
kernels (with SIMD support).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
