alamb commented on code in PR #5470:
URL: https://github.com/apache/arrow-rs/pull/5470#discussion_r1511853005
##########
arrow-data/src/equal/mod.rs:
##########
@@ -96,6 +96,7 @@ fn equal_values(
variable_sized_equal::<i64>(lhs, rhs, lhs_start, rhs_start, len)
}
DataType::FixedSizeBinary(_) => fixed_binary_equal(lhs, rhs,
lhs_start, rhs_start, len),
+ DataType::BinaryView | DataType::Utf8View => unimplemented!("Not
implemented"),
Review Comment:
It might be nice to add a little more context to the errors
```suggestion
DataType::BinaryView | DataType::Utf8View =>
unimplemented!("BinaryView/Utf8View not yet implemented"),
```
##########
arrow-ipc/src/convert.rs:
##########
@@ -543,6 +543,7 @@ pub(crate) fn get_fb_field_type<'a>(
.as_union_value(),
children: Some(fbb.create_vector(&empty_fields[..])),
},
+ BinaryView | Utf8View => unimplemented!("Not implemented"),
Review Comment:
This is a good reminder that we need to implement IPC support as well -- I
added that as a task to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
