alamb commented on code in PR #5470:
URL: https://github.com/apache/arrow-rs/pull/5470#discussion_r1511863439
##########
arrow-schema/src/datatype.rs:
##########
@@ -206,6 +213,13 @@ pub enum DataType {
/// A single LargeUtf8 array can store up to [`i64::MAX`] bytes
/// of string data in total.
LargeUtf8,
+ /// A variable-length string in Unicode with UTF-8 encoding
Review Comment:
```suggestion
/// (NOT YET FULLY SUPPORTED) A variable-length string in Unicode with
UTF-8 encoding
///
/// Note this data type is not yet fully supported. Using it with arrow
APIs may result in `panic`s.
```
##########
arrow-schema/src/datatype.rs:
##########
@@ -196,6 +196,13 @@ pub enum DataType {
/// A single LargeBinary array can store up to [`i64::MAX`] bytes
/// of binary data in total.
LargeBinary,
+ /// Opaque binary data of variable length.
+ ///
+ /// Logically the same as [`Self::Binary`], but the internal
representation uses a view
+ /// struct that contains the string length and either the string's entire
data
+ /// inline (for small strings) or an inlined prefix, an index of another
buffer,
+ /// and an offset pointing to a slice in that buffer (for non-small
strings).
Review Comment:
```suggestion
/// (NOT YET FULLY SUPPORTED) Opaque binary data of variable length.
///
/// Note this data type is not yet fully supported. Using it with arrow
APIs may result in `panic`s.
///
/// Logically the same as [`Self::Binary`], but the internal
representation uses a view
/// struct that contains the string length and either the string's
entire data
/// inline (for small strings) or an inlined prefix, an index of another
buffer,
/// and an offset pointing to a slice in that buffer (for non-small
strings).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
