XiangpengHao commented on PR #5470:
URL: https://github.com/apache/arrow-rs/pull/5470#issuecomment-1977889891

   > I am pleasantly surprised by how few places in the code needed to be 
changed.
   
   I mostly rely on the compiler to find where to add unimplemented!(). Other 
cases like:
   ```rust
   match data_type {
     DataType::some_thing => {}
     _ => {}
   }
   ```
   
https://github.com/XiangpengHao/arrow-rs/blob/d861177a5d0171fab8d4f646d3b72dfabf83b14d/rust/arrow/src/datatypes/field.rs#L124
   
   Might require a closer look to make sure they are safe to escape


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to