jduo commented on code in PR #1593:
URL: https://github.com/apache/arrow-adbc/pull/1593#discussion_r1515980559
##########
csharp/test/Apache.Arrow.Adbc.Tests/Metadata/GetObjectsParser.cs:
##########
@@ -173,6 +173,14 @@ private static List<AdbcConstraint>
ParseConstraints(StructArray constraintsArra
StringArray col_names = column_names.GetSlicedValues(i) as
StringArray;
StructArray usage = column_usage.GetSlicedValues(i) as
StructArray;
+ if (col_names != null)
+ {
+ for (int j = 0; j < col_names.Length; j++)
Review Comment:
We should reserve a capacity on the target list since the number of columns
can be large.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
