devinjdangelo commented on code in PR #9604: URL: https://github.com/apache/arrow-datafusion/pull/9604#discussion_r1525407527
########## datafusion/sqllogictest/test_files/clickbench.slt: ########## @@ -23,7 +23,7 @@ # create.sql came from # https://github.com/ClickHouse/ClickBench/blob/8b9e3aa05ea18afa427f14909ddc678b8ef0d5e6/datafusion/create.sql # Data file made with DuckDB: -# COPY (SELECT * FROM 'hits.parquet' LIMIT 10) TO 'clickbench_hits_10.parquet' (FORMAT PARQUET); +# COPY (SELECT * FROM 'hits.parquet' LIMIT 10) TO 'clickbench_hits_10.parquet' STORED AS PARQUET; Review Comment: Here I think we should also maintain backwards compatibility. It is nice to have a dedicated keyword for the often required format option, but I think user's queries in the old syntax should continue working ########## datafusion/sql/tests/sql_integration.rs: ########## @@ -397,7 +397,7 @@ CopyTo: format=csv output_url=output.csv options: () #[test] fn plan_explain_copy_to() { - let sql = "EXPLAIN COPY test_decimal to 'output.csv'"; + let sql = "EXPLAIN COPY test_decimal to 'output.csv' STORED AS CSV"; Review Comment: I think we should continue to support the original syntax here, which is in my opinion much more clear and concise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
