devinjdangelo commented on code in PR #9623:
URL: https://github.com/apache/arrow-datafusion/pull/9623#discussion_r1526328504
##########
datafusion/sql/src/unparser/plan.rs:
##########
@@ -215,7 +163,11 @@ impl Unparser<'_> {
LogicalPlan::Filter(filter) => {
let filter_expr = self.expr_to_sql(&filter.predicate)?;
- select.selection(Some(filter_expr));
+ if let LogicalPlan::Aggregate(_) = filter.input.as_ref(){
Review Comment:
I suspect we will find more test cases where this logic is not sufficient to
determine if a filter should be in a HAVING or WHERE clause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
