devinjdangelo commented on code in PR #9623:
URL: https://github.com/apache/arrow-datafusion/pull/9623#discussion_r1527526305


##########
datafusion/sql/src/unparser/expr.rs:
##########
@@ -151,6 +151,36 @@ impl Unparser<'_> {
                     order_by: vec![],
                 }))
             }
+            Expr::ScalarSubquery(subq) => {

Review Comment:
   If you look at `Unparser::select_to_sql_recursively`, we have not 
implemented a match condition for `LogicalPlan::Subquery`. This node is never 
actually encountered as I have not found a case where you can get to it via the 
"input" of another node. We do encounter the Expr::ScalarSubquery expression 
and we encode the information from the `LogicalPlan` found there instead. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to