seddonm1 commented on PR #9623: URL: https://github.com/apache/arrow-datafusion/pull/9623#issuecomment-2002604704
I think your change to the roundtrip test is good as it is testing only the single concern of `Statement -> AST` rather than the dual concerns of `Statement -> AST` + `sqlparser formatting behavior`. I wonder if it makes sense to change `expr_to_sql_ok` to behave similarly? Theoretically the sqlparser-rs crate has serialisation tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
