felipecrv commented on code in PR #40608:
URL: https://github.com/apache/arrow/pull/40608#discussion_r1527536374
##########
cpp/src/arrow/compute/expression.cc:
##########
@@ -845,7 +845,7 @@ Result<Expression> FoldConstants(Expression expr) {
std::move(expr), [](Expression expr) { return expr; },
[](Expression expr, ...) -> Result<Expression> {
auto call = CallNotNull(expr);
- if (call->function->is_impure()) return expr;
+ if (!call->function->is_pure()) return expr;
Review Comment:
Understandable. You did what is best for what you were trying to accomplish
— skip impure functions, but I'm trying to simplify the
configuration/implementation for function implementers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
