mapleFU commented on code in PR #40608:
URL: https://github.com/apache/arrow/pull/40608#discussion_r1528308696
##########
cpp/src/arrow/compute/function.h:
##########
@@ -297,10 +299,10 @@ class ARROW_EXPORT ScalarFunction : public
detail::FunctionImpl<ScalarKernel> {
using KernelType = ScalarKernel;
ScalarFunction(std::string name, const Arity& arity, FunctionDoc doc,
- const FunctionOptions* default_options = NULLPTR, bool
is_impure = false)
+ const FunctionOptions* default_options = NULLPTR, bool
is_pure = true)
Review Comment:
I like this modification, but I also wonded that, would this affect legacy
user with self defined "impure"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
