bkietz commented on code in PR #40608:
URL: https://github.com/apache/arrow/pull/40608#discussion_r1528754219
##########
cpp/src/arrow/compute/kernels/hash_aggregate.cc:
##########
@@ -3454,8 +3454,8 @@ void RegisterHashAggregateBasic(FunctionRegistry*
registry) {
}
{
- auto func = std::make_shared<HashAggregateFunction>("hash_count_all",
Arity::Unary(),
- hash_count_all_doc,
NULLPTR);
+ auto func = std::make_shared<HashAggregateFunction>(
+ "hash_count_all", Arity::Nullary(), hash_count_all_doc, NULLPTR);
DCHECK_OK(func->AddKernel(MakeUnaryKernel(HashAggregateInit<GroupedCountAllImpl>)));
Review Comment:
I had forgotten this: all hash aggregate kernels receive an extra argument
containing group ids. That's an argument to the kernel but *not* to the
Function (because group IDs must be assembled from the batch)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
