kou commented on code in PR #40514:
URL: https://github.com/apache/arrow/pull/40514#discussion_r1532122122
##########
dev/release/verify-release-candidate.sh:
##########
@@ -468,6 +469,16 @@ install_conda() {
conda activate base
}
+install_maven() {
+ show_info "Installing Maven version ${MAVEN_VERSION}..."
Review Comment:
Could you install only when system Maven is older than 3.8.7?
See `install_nodejs()` how to implement it.
##########
dev/release/verify-release-candidate.sh:
##########
@@ -566,6 +577,7 @@ test_package_java() {
show_header "Build and test Java libraries"
maybe_setup_conda maven openjdk
+ install_maven
Review Comment:
Could you use the following style like others?
```bash
maybe_setup_maven
maybe_setup_conda maven openjdk
```
##########
dev/release/verify-release-candidate.sh:
##########
@@ -468,6 +469,16 @@ install_conda() {
conda activate base
}
+install_maven() {
+ show_info "Installing Maven version ${MAVEN_VERSION}..."
+
APACHE_MIRROR="http://www.apache.org/dyn/closer.cgi?action=download&filename=";
+ curl -sL -o apache-maven-${MAVEN_VERSION}-bin.tar.gz \
+
${APACHE_MIRROR}/maven/maven-3/${MAVEN_VERSION}/binaries/apache-maven-${MAVEN_VERSION}-bin.tar.gz
+ tar xzf apache-maven-${MAVEN_VERSION}-bin.tar.gz
+ export PATH=`pwd`/apache-maven-${MAVEN_VERSION}/bin:$PATH
Review Comment:
```suggestion
export PATH=$(pwd)/apache-maven-${MAVEN_VERSION}/bin:$PATH
```
##########
dev/release/verify-release-candidate.sh:
##########
@@ -468,6 +469,16 @@ install_conda() {
conda activate base
}
+install_maven() {
Review Comment:
We can use only https://www.apache.org/dyn/closer.lua . We don't need to use
mirrors.
See also: https://infra.apache.org/release-download-pages.html#download-page
##########
dev/release/verify-release-candidate.sh:
##########
@@ -76,6 +76,7 @@ esac
# which is different from the ARROW_SOURCE_DIR set in ensure_source_directory()
SOURCE_DIR="$(cd "$(dirname "${BASH_SOURCE[0]:-$0}")" && pwd)"
ARROW_DIR="$(cd "${SOURCE_DIR}/../.." && pwd)"
+MAVEN_VERSION=3.8.7
Review Comment:
Could you define this in `install_maven()`?
##########
dev/release/verify-release-candidate.sh:
##########
@@ -468,6 +469,16 @@ install_conda() {
conda activate base
}
+install_maven() {
+ show_info "Installing Maven version ${MAVEN_VERSION}..."
+
APACHE_MIRROR="http://www.apache.org/dyn/closer.cgi?action=download&filename=";
Review Comment:
Could you use `https` and `.lua`?
See also: https://infra.apache.org/release-download-pages.html#download-page
```suggestion
APACHE_MIRROR="https://www.apache.org/dyn/closer.lua?action=download&filename=";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
