vibhatha commented on code in PR #40514:
URL: https://github.com/apache/arrow/pull/40514#discussion_r1533113553


##########
dev/release/verify-release-candidate.sh:
##########
@@ -468,6 +468,22 @@ install_conda() {
   conda activate base
 }
 
+maybe_setup_maven() {
+  MAVEN_VERSION=3.8.7
+  SYSTEM_MAVEN_VERSION=$(mvn -v | head -n 1 | awk '{print $3}')
+  if [[ $(echo "$SYSTEM_MAVEN_VERSION $MAVEN_VERSION" | awk '{print ($1 < 
$2)}') -eq 1 ]]; then

Review Comment:
   @ianmcook looking into this I found 
https://docs.oracle.com/middleware/1212/core/MAVEN/maven_version.htm#MAVEN8855
   
   If we go for `alpha`, `beta` like versioning, the logic gets a bit 
complicated and it is not as straightforward as it is done for node since it is 
numbers. I wrote a few versions of version checkers now and tested. I am still 
verifying...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to