ianmcook commented on code in PR #40514:
URL: https://github.com/apache/arrow/pull/40514#discussion_r1532941346
##########
dev/release/verify-release-candidate.sh:
##########
@@ -468,6 +468,22 @@ install_conda() {
conda activate base
}
+maybe_setup_maven() {
+ MAVEN_VERSION=3.8.7
+ SYSTEM_MAVEN_VERSION=$(mvn -v | head -n 1 | awk '{print $3}')
+ if [[ $(echo "$SYSTEM_MAVEN_VERSION $MAVEN_VERSION" | awk '{print ($1 <
$2)}') -eq 1 ]]; then
Review Comment:
Problem here: If any of the version parts have 2 digits (which [can
happen](https://maven.apache.org/docs/history.html)), this could fail. For
example:
```sh
echo "3.8.10 3.8.7" | awk '{print ($1 < $2)}'
```
gives `1`, but we wouldn't want to upgrade in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
