paleolimbot commented on code in PR #406:
URL: https://github.com/apache/arrow-nanoarrow/pull/406#discussion_r1532503949
##########
CMakeLists.txt:
##########
@@ -154,13 +154,48 @@ else()
endif()
endif()
- install(TARGETS nanoarrow DESTINATION lib)
+ install(TARGETS nanoarrow
+ DESTINATION lib
+ EXPORT nanoarrow-exports)
+ install(TARGETS coverage_config
+ DESTINATION lib
+ EXPORT nanoarrow-exports)
Review Comment:
I think the namespacing is a good idea...I am not worried about existing
users because everybody should be pinning a version right now (and we've made
it pretty easy to do), and because our CMake configuration was almost unusable
before this PR. I'm not sure if `ipc` should be `ipc` or `nanoarrow_ipc` (but
that's a decision for later anyway).
Either way, the coverage configuration should almost certainly not be
exported? It should really only be defined if `NANOARROW_BUILD_TESTS=ON` anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
