simonvandel commented on PR #9595:
URL:
https://github.com/apache/arrow-datafusion/pull/9595#issuecomment-2012440166
> I ran these commands. I am rerunning them now to regather the numbers
>
> ```
> git checkout feat/make-dfschema-wrap-schemaref
> cargo bench --bench sql_planner -- all --save-baseline before
>
> MERGE_BASE=$(git merge-base HEAD apache/main)
> echo "** Comparing to ${MERGE_BASE}"
>
> git checkout ${MERGE_BASE}
> cargo bench --bench sql_planner -- all --save-baseline change
>
> critcmp before change
> ```
Isn't your "before" and "change" reversed?
the before should be at the merge-base, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
