jayzhan211 commented on code in PR #9595:
URL: https://github.com/apache/arrow-datafusion/pull/9595#discussion_r1531910797
##########
datafusion/common/src/dfschema.rs:
##########
@@ -119,74 +120,113 @@ impl DFSchema {
/// Creates an empty `DFSchema`
pub fn empty() -> Self {
Self {
- fields: vec![],
- metadata: HashMap::new(),
+ inner: Arc::new(Schema::new([])),
+ field_qualifiers: vec![],
functional_dependencies: FunctionalDependencies::empty(),
}
}
- /// Create a new `DFSchema`
+ /// Create a new `DFSchema` from an Arrow schema
pub fn new_with_metadata(
- fields: Vec<DFField>,
+ fields: Vec<Field>,
Review Comment:
I think we can use`Fields` here, since Schema::new_with_metadata also expect
`Feilds`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
