haohuaijin commented on code in PR #9595:
URL: https://github.com/apache/arrow-datafusion/pull/9595#discussion_r1533402746
##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -374,28 +376,44 @@ impl ExprSchemable for Expr {
///
/// So for example, a projected expression `col(c1) + col(c2)` is
/// placed in an output field **named** col("c1 + c2")
- fn to_field(&self, input_schema: &dyn ExprSchema) -> Result<DFField> {
+ fn to_field(
+ &self,
+ input_schema: &dyn ExprSchema,
+ ) -> Result<(Option<OwnedTableReference>, Arc<Field>)> {
Review Comment:
> There are some places with owned DFField, some with referenced. Should we
have two struct one for owned, another for referenced? 🤔
@jayzhan211 as @alamb said, maybe we can in follow pr make OwnTableReference
as Arc<str>, then all places will be a reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
