pitrou commented on code in PR #40761: URL: https://github.com/apache/arrow/pull/40761#discussion_r1537413290
########## python/pyarrow/types.py: ########## @@ -64,17 +82,17 @@ def is_boolean(t): @doc(is_null, datatype="any integer") def is_integer(t): - return t.id in _INTEGER_TYPES + return is_integer_type(t) Review Comment: Hmm... why are we defining two sets of functions exactly? We should have either `is_integer` or `is_integer_type`, not both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
