domoritz commented on code in PR #40852:
URL: https://github.com/apache/arrow/pull/40852#discussion_r1542111250
##########
js/src/data.ts:
##########
@@ -177,16 +180,16 @@ export class Data<T extends DataType = DataType> {
// if we have a nullBitmap, truncate + slice and set it over
the pre-filled 1s
if (this.nullCount > 0) {
nullBitmap.set(truncateBitmap(offset, length,
this.nullBitmap), 0);
+ Object.assign(this, { nullBitmap });
Review Comment:
If we assign null count here, the update to the null count will be wrong.
Also, we know that the null count has not yet changed so there is no need to
set it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
