domoritz commented on code in PR #40852:
URL: https://github.com/apache/arrow/pull/40852#discussion_r1542112852
##########
js/src/vector.ts:
##########
@@ -445,7 +445,7 @@ export function makeVector(init: any) {
if (init instanceof DataView) {
init = new Uint8Array(init.buffer);
}
- const props = { offset: 0, length: init.length, nullCount: 0,
data: init };
+ const props = { offset: 0, length: init.length, nullCount: -1,
data: init };
Review Comment:
`_nullCount != 0 && (!nullBitmap || nullBitmap.byteLength == 0)` is not
nullable so we set `-1` as the null count here to mark the data as not
nullable. `makeData` will always create a null bitmap so I'm not sure why we
need to check for no bitmap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
