domoritz commented on code in PR #40852:
URL: https://github.com/apache/arrow/pull/40852#discussion_r1542111803
##########
js/src/data.ts:
##########
@@ -177,16 +180,16 @@ export class Data<T extends DataType = DataType> {
// if we have a nullBitmap, truncate + slice and set it over
the pre-filled 1s
if (this.nullCount > 0) {
nullBitmap.set(truncateBitmap(offset, length,
this.nullBitmap), 0);
+ Object.assign(this, { nullBitmap });
+ } else {
+ Object.assign(this, { nullBitmap, _nullCount: 0 });
Review Comment:
Here we can set the null count to 0 since we just created a new nullBitmap
that is all valid values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
