jayzhan211 commented on code in PR #9874:
URL: https://github.com/apache/arrow-datafusion/pull/9874#discussion_r1545647195
##########
datafusion/expr/src/expr_fn.rs:
##########
@@ -796,15 +809,101 @@ impl AggregateUDFImpl for SimpleAggregateUDF {
Ok(self.return_type.clone())
}
- fn accumulator(&self, arg: &DataType) -> Result<Box<dyn
crate::Accumulator>> {
- (self.accumulator)(arg)
+ fn accumulator(
+ &self,
+ arg: &DataType,
+ sort_exprs: &[Expr],
+ schema: &Schema,
+ _ignore_nulls: bool,
+ _requirement_satisfied: bool,
+ ) -> Result<Box<dyn crate::Accumulator>> {
+ (self.accumulator)(arg, sort_exprs, schema)
}
fn state_type(&self, _return_type: &DataType) -> Result<Vec<DataType>> {
Ok(self.state_type.clone())
}
}
+pub struct FirstValue {
Review Comment:
I tried moving it to `datafusion-functions-aggregates`, but not sure how to
avoid importing physical-expr, it is largely used, including `PhysicalSortExpr`
and `AggreagteExpr`. 🤔
##########
datafusion/expr/src/expr_fn.rs:
##########
@@ -796,15 +809,101 @@ impl AggregateUDFImpl for SimpleAggregateUDF {
Ok(self.return_type.clone())
}
- fn accumulator(&self, arg: &DataType) -> Result<Box<dyn
crate::Accumulator>> {
- (self.accumulator)(arg)
+ fn accumulator(
+ &self,
+ arg: &DataType,
+ sort_exprs: &[Expr],
+ schema: &Schema,
+ _ignore_nulls: bool,
+ _requirement_satisfied: bool,
+ ) -> Result<Box<dyn crate::Accumulator>> {
+ (self.accumulator)(arg, sort_exprs, schema)
}
fn state_type(&self, _return_type: &DataType) -> Result<Vec<DataType>> {
Ok(self.state_type.clone())
}
}
+pub struct FirstValue {
Review Comment:
I had tried moving it to `datafusion-functions-aggregates`, but not sure how
to avoid importing physical-expr, it is largely used, including
`PhysicalSortExpr` and `AggreagteExpr`. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
