mustafasrepo commented on code in PR #9874:
URL: https://github.com/apache/arrow-datafusion/pull/9874#discussion_r1546116470
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -1457,6 +1461,22 @@ impl SessionState {
datafusion_functions_array::register_all(&mut new_self)
.expect("can not register array expressions");
+ let first_value = create_first_value(
+ "FIRST_VALUE",
+ Signature::uniform(1, NUMERICS.to_vec(), Volatility::Immutable),
+ Arc::new(create_first_value_accumulator),
+ );
+
+ match new_self.register_udaf(Arc::new(first_value)) {
+ Ok(Some(existing_udaf)) => {
+ debug!("Overwrite existing UDF: {}", existing_udaf.name());
Review Comment:
```suggestion
debug!("Overwrite existing UDAF: {}", existing_udaf.name());
```
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -1457,6 +1461,22 @@ impl SessionState {
datafusion_functions_array::register_all(&mut new_self)
.expect("can not register array expressions");
+ let first_value = create_first_value(
+ "FIRST_VALUE",
+ Signature::uniform(1, NUMERICS.to_vec(), Volatility::Immutable),
+ Arc::new(create_first_value_accumulator),
+ );
+
+ match new_self.register_udaf(Arc::new(first_value)) {
+ Ok(Some(existing_udaf)) => {
+ debug!("Overwrite existing UDF: {}", existing_udaf.name());
+ }
+ Ok(None) => {}
+ Err(err) => {
+ panic!("Failed to register UDF: {}", err);
Review Comment:
```suggestion
panic!("Failed to register UDAF: {}", err);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
