jayzhan211 commented on code in PR #9874:
URL: https://github.com/apache/arrow-datafusion/pull/9874#discussion_r1545707973


##########
datafusion/expr/src/function.rs:
##########
@@ -37,10 +38,37 @@ pub type ScalarFunctionImplementation =
 pub type ReturnTypeFunction =
     Arc<dyn Fn(&[DataType]) -> Result<Arc<DataType>> + Send + Sync>;
 
+/// Arguments passed to create an accumulator
+pub struct AccumulatorArgs<'a> {

Review Comment:
   I think we dont need to verify the `sort_exprs` is provided by user or not, 
because It is given only if `order by` expression is provided.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to