hzuo commented on code in PR #5554:
URL: https://github.com/apache/arrow-rs/pull/5554#discussion_r1546785723
##########
arrow-ipc/src/reader.rs:
##########
@@ -628,6 +688,19 @@ impl FileDecoder {
self
}
+ /// Specify whether to enforce zero copy, which means the array data
inside the record batches
+ /// produced by this decoder will always reference the input buffer.
Review Comment:
Yeah I agree, will make this change.
My original thinking was that there might be a variety of reasons why IPC
decoders may need to create a copy of the input data, and this would be a
catch-all so that the users don't have to understand the intricacies of why or
why not copies need to be made.
But agree that it ends up being kinda vague, and in the future if there are
other reasons copies need to be made, probably better to expose each of the
"reasons" as a granular "requirement" - if there ends up being a ton, we can
expose a catch-all, but no reason to anticipate that today at the expense of
clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
