hzuo commented on code in PR #5554:
URL: https://github.com/apache/arrow-rs/pull/5554#discussion_r1546796957
##########
arrow-ipc/src/reader.rs:
##########
@@ -1801,11 +1878,56 @@ mod tests {
&Default::default(),
None,
&message.version(),
+ false,
)
.unwrap();
assert_eq!(batch, roundtrip);
}
+ #[test]
+ fn test_unaligned_throws_error_with_enforce_zero_copy() {
+ let batch = RecordBatch::try_from_iter(vec![(
+ "i32",
+ Arc::new(Int32Array::from(vec![1, 2, 3, 4])) as _,
+ )])
+ .unwrap();
+
+ let gen = IpcDataGenerator {};
+ let mut dict_tracker = DictionaryTracker::new(false);
+ let (_, encoded) = gen
+ .encoded_batch(&batch, &mut dict_tracker, &Default::default())
+ .unwrap();
+
+ let message = root_as_message(&encoded.ipc_message).unwrap();
+
+ // Construct an unaligned buffer
+ let mut buffer = MutableBuffer::with_capacity(encoded.arrow_data.len()
+ 1);
+ buffer.push(0_u8);
+ buffer.extend_from_slice(&encoded.arrow_data);
+ let b = Buffer::from(buffer).slice(1);
+ assert_ne!(b.as_ptr().align_offset(8), 0);
+
+ let ipc_batch = message.header_as_record_batch().unwrap();
+ let result = read_record_batch(
+ &b,
+ ipc_batch,
+ batch.schema(),
+ &Default::default(),
+ None,
+ &message.version(),
+ true,
+ );
+
+ let error = result.unwrap_err();
+ match error {
+ ArrowError::InvalidArgumentError(e) => {
+ assert!(e.contains("Misaligned"));
+ assert!(e.contains("offset from expected alignment of"));
+ }
+ _ => panic!("Expected InvalidArgumentError"),
+ }
Review Comment:
for sure - but the error message is dynamic so I figured a strict equality
check was too strict - e.g. if the error message formatting or some debug impl
changes, should I care about that in this test?
happy to do a strict equality check if that's generally the style in this
repo!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
