hzuo commented on code in PR #5554:
URL: https://github.com/apache/arrow-rs/pull/5554#discussion_r1546793073


##########
arrow-integration-testing/src/flight_server_scenarios/integration_test.rs:
##########
@@ -308,6 +308,7 @@ async fn record_batch_from_message(
         dictionaries_by_id,
         None,
         &message.version(),
+        false,

Review Comment:
   Probably wouldn't fail - I didn't read through the full integration test but 
as long as it's not using Decimal128 then 8-byte alignment is sufficient, so it 
should succeed even with `require_alignment=true`.
   
   Passing `false` is equivalent to the previous behavior where a copy was 
automatically made if the data was unaligned, so I didn't want to introduce new 
behavior to existing tests.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to