alamb commented on code in PR #9874:
URL: https://github.com/apache/arrow-datafusion/pull/9874#discussion_r1548382311
##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -912,15 +912,17 @@ mod test {
fn agg_udaf_invalid_input() -> Result<()> {
let empty = empty();
let return_type = DataType::Float64;
- let state_type = vec![DataType::UInt64, DataType::Float64];
let accumulator: AccumulatorFactoryFunction =
Arc::new(|_| Ok(Box::<AvgAccumulator>::default()));
let my_avg = AggregateUDF::from(SimpleAggregateUDF::new_with_signature(
"MY_AVG",
Signature::uniform(1, vec![DataType::Float64],
Volatility::Immutable),
return_type,
accumulator,
- state_type,
+ vec![
+ Field::new("count", DataType::UInt64, true),
Review Comment:
I actually think this is a nice change that the fields are now named rather
than anonymous
I think @jacksonrnewhouse mentioned this might be helpful for his project as
well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
