lidavidm commented on code in PR #40988:
URL: https://github.com/apache/arrow/pull/40988#discussion_r1550908906


##########
java/flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/ArrowDatabaseMetadata.java:
##########
@@ -754,7 +754,11 @@ private <T> T getSqlInfoAndCacheIfCacheIsEmpty(final 
SqlInfo sqlInfoCommand,
   }
 
   private String convertListSqlInfoToString(final List<?> sqlInfoList) {

Review Comment:
   I think it would make more sense to return `Optional<String>` and update 
client code to explicitly decide what they want to do with missing values.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to