jayzhan211 commented on code in PR #9960:
URL: https://github.com/apache/arrow-datafusion/pull/9960#discussion_r1553707553
##########
datafusion/aggregate-functions/src/first_last.rs:
##########
@@ -393,53 +339,190 @@ impl Accumulator for FirstValueAccumulator {
}
}
-pub fn create_first_value_accumulator(
- acc_args: AccumulatorArgs,
-) -> Result<Box<dyn Accumulator>> {
- let mut all_sort_orders = vec![];
+/// TO BE DEPRECATED: Builtin FIRST_VALUE physical aggregate expression
+#[derive(Debug, Clone)]
+pub struct FirstValuePhysicalExpr {
Review Comment:
Rename to differentiate, will be remove later on, same to last value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
