jayzhan211 commented on code in PR #9960:
URL: https://github.com/apache/arrow-datafusion/pull/9960#discussion_r1553711502
##########
datafusion/expr/src/utils.rs:
##########
@@ -1240,6 +1240,12 @@ pub fn merge_schema(inputs: Vec<&LogicalPlan>) ->
DFSchema {
}
}
+/// Construct state name. State is the intermidiate state of the aggregate
function.
+/// TODO: Remove duplicated function in physical-expr
+pub fn format_state_name(name: &str, state_name: &str) -> String {
Review Comment:
move to utils
##########
datafusion/expr/src/utils.rs:
##########
@@ -1240,6 +1240,12 @@ pub fn merge_schema(inputs: Vec<&LogicalPlan>) ->
DFSchema {
}
}
+/// Construct state name. State is the intermidiate state of the aggregate
function.
+/// TODO: Remove duplicated function in physical-expr
+pub fn format_state_name(name: &str, state_name: &str) -> String {
Review Comment:
move to utils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
