jayzhan211 commented on code in PR #9960:
URL: https://github.com/apache/arrow-datafusion/pull/9960#discussion_r1554443953
##########
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -612,6 +612,7 @@ async fn roundtrip_expr_api() -> Result<()> {
lit(1),
),
array_replace_all(make_array(vec![lit(1), lit(2), lit(3)]), lit(2),
lit(4)),
+ // TODO: Add first value after built-in functions are deprecated
Review Comment:
You are right. Sorry for leaving this confusing comment. I should have left
it in the review comment, not in the code 😆
I plan to support the `expr` API with arguments like distinct, and ordering
after I deprecated all the built-in functions.
However, I added a simple example with lit(1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
